apache / apache/datafusion-python

Update `build-sdist` job

未关闭
#832 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
604
派生
174
平均合并
1 天 7 小时
30 天内合并 PR
4

描述

Follow on from #829

## The Issue
`build-sdist` does not generate any artifact.

The `actions/upload-artifact` step is looking to archive files in `target/wheels/*`, which `sdist` builds do not generate.

The generated archive from the logs ([reference job run](https://github.com/apache/datafusion-python/actions/runs/10501567861/job/29091775728)):

```console
Built source distribution to /home/runner/work/datafusion-python/datafusion-python/dist/datafusion-40.0.0.tar.gz
```

## Context
The release documentation currently expects only `wheels` to be included in `dist.zip` and for the `sdist` to be generated manually.

https://github.com/apache/datafusion-python/blob/805183bd9ae32b628e641d9552f1d0dded4a7a85/dev/release/README.md?plain=1#L142-L155

## Options

- Update the step to upload the tar archive as an artifact and update the release docs to use that.
- Update the step to assert that no wheels are generated in `target/wheels/*`, which will verify the sdist build and ensure the behavior doesn't change under our feet.
- Remove the step altogether.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。