apache / apache/datafusion-python

Remove all uses of `todo!`

已關閉
#552 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
Python
星號
604
分支
174
平均合併
1 天 7 小時
30 天內合併 PR
4

描述

**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**

We have a number of uses of `todo!` that we should replace with use of `Err`.

```
$ find . -name "*.rs" -exec grep -H "todo\!" {} \;
./src/expr/indexed_field.rs: _ => todo!(),
./src/expr.rs: ScalarValue::Null => todo!(),
./src/expr.rs: ScalarValue::Decimal256(_, _, _) => todo!(),
./src/expr.rs: ScalarValue::FixedSizeBinary(_, _) => todo!(),
./src/expr.rs: ScalarValue::List(_) => todo!(),
./src/expr.rs: ScalarValue::Struct(_, _) => todo!(),
./src/expr.rs: ScalarValue::Dictionary(_, _) => todo!(),
./src/expr.rs: ScalarValue::FixedSizeList(_) => todo!(),
./src/expr.rs: ScalarValue::LargeList(_) => todo!(),
./src/expr.rs: Operator::AtArrow | Operator::ArrowAt => todo!(),
./src/common/data_type.rs: todo!()
./src/common/data_type.rs: ScalarValue::LargeList(_) => todo!(),
```

**Describe the solution you'd like**

**Describe alternatives you've considered**

**Additional context**

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

Start with the `todo!` matches in `src/expr/indexed_field.rs`, `src/expr.rs`, and `src/common/data_type.rs`, then trace the surrounding result and error handling. Check how these expression and data type paths represent unsupported cases and identify the relevant tests before replacing each placeholder. Done means the listed Rust sources contain no `todo!` uses and the existing test suite passes.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
rust
領域
backend
Issue 類型
重構
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
30/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。