apache / apache/datafusion-python

Rewrite the "Encode metadata, not a handle to a live object" section

Offen Anfängerfreundlich
#1,726 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
documentation
Vorherrschende Sprache
Python
Sterne
604
Forks
174
Ø Merge
1 T. 7 Std.
Gemergte PRs (30 T.)
4

Beschreibung

Blocked on the two sub-issues above — this describes the state they produce.

#1721 corrected the factually wrong attribution in `extension-guide/codecs.md` (it named `datafusion-ffi-query-planner-example`, which has no registry) and connected the broad claim at line 185 to the registry it forces. That was deliberately minimal, because the underlying facts were about to change.

Once the logical codec encodes durable metadata and the greedy arm is quarantined, the section should be rewritten rather than patched again:

- **Lead with the positive example.** Two paragraphs of what-not-to-do before the reader sees a correct codec is the wrong order.
- **State the registry as a consequence, not a choice.** A codec that downcasts to its own concrete types is never handed something it cannot describe. The cause is already explained under `extension_codec_order`, 100 lines further down; the two should link to each other.
- **Name the one remaining offender precisely** — the `ForeignExecutionPlan` arm, with the upstream issue and the delete-when condition, so a reader can tell a marked workaround from sloppiness.
- `datafusion-ffi-example`'s logical codec moves from the counter-example list to the example list, alongside `examples/distributed/storage-library`.

Also check `extension-guide/checklist.md:109`, which says "the examples in this repository use tokens to make ownership observable" — that becomes true of one arm of one codec rather than of the examples generally.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start by reading extension-guide/codecs.md around the section being rewritten, then review the two blocking sub-issues and extension-guide/checklist.md:109 to confirm the resulting facts. Move datafusion-ffi-example into the positive examples, explain the registry consequence, and identify the remaining ForeignExecutionPlan workaround with its upstream issue and deletion condition; update the checklist wording accordingly.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
markdown
Bereich
documentation
Issue-Typ
Dokumentation
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
72/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.