apache / apache/cloudstack

UI: a role denied one non-essential bootstrap API (e.g. listLdapConfigurations) fails to load the entire console

未关闭 适合新手
#13,912 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
component:UI
主要语言
Java
星标
3.1k
派生
1.4k
平均合并
6 天 19 小时
30 天内合并 PR
32

描述

### problem

The web console fails to load entirely for any role denied one non-essential bootstrap read. [`GetInfo`](https://github.com/apache/cloudstack/blob/main/ui/src/store/modules/user.js#L326) runs several independent calls under a single shared `Promise` and wires several to the same `reject`, including [`listLdapConfigurations`](https://github.com/apache/cloudstack/blob/main/ui/src/store/modules/user.js#L493-L497), which only sets a flag. When a role denies it the 432 rejects the shared promise before [`listApis`](https://github.com/apache/cloudstack/blob/main/ui/src/store/modules/user.js#L415) can resolve it (a race the small query usually wins), so `GetInfo` rejects and the [router guard](https://github.com/apache/cloudstack/blob/main/ui/src/permission.js#L150-L167) logs the user out instead of building routes. The tolerant pattern sits right beside it: [`listNetworkServiceProviders`](https://github.com/apache/cloudstack/blob/main/ui/src/store/modules/user.js#L485) swallows its own error and the console still loads (`listGuiThemes` likewise).

**Expected:** a denied non-essential read degrades like `listNetworkServiceProviders`/`listGuiThemes`. **Actual:** blank console, redirect to `/user/login`.

### versions

4.22 and current `main`. Client-side UI only; hypervisor/storage/network irrelevant.

### The steps to reproduce the bug

1. Create a custom role (e.g. from the DomainAdmin base type) that denies `listLdapConfigurations`.
2. Assign an account to it.
3. Log in to the web UI — the console never renders and you are redirected to login.

### What to do about it?

Give `listLdapConfigurations` (and any non-essential bootstrap read) its own `.catch` that defaults the flag, as [`listNetworkServiceProviders`](https://github.com/apache/cloudstack/blob/main/ui/src/store/modules/user.js#L485) already does. The underlying hazard is the shared `resolve`/`reject` across independent calls in `GetInfo`; reserve `reject` for genuinely essential calls such as `listApis`.

贡献指南

打开贡献指南

调研方向

从 ui/src/store/modules/user.js 中的 GetInfo 开始,重点查看 listLdapConfigurations 以及容错的 listNetworkServiceProviders/listGuiThemes 处理器。检查 ui/src/permission.js 以了解路由守卫的失败路径。完成的标准是:被拒绝的非必要 bootstrap 读取将其标志设置为默认值,而不会拒绝 GetInfo,从而加载控制台,而不是重定向到 /user/login。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
frontend
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
活跃
描述清晰度
描述清楚
新手友好度
85/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。