apache / apache/cloudstack

Global setting oauth2.plugins

未關閉
#13,862 1 則留言 0 個 reaction 已指派 1 人 已被 @Damans227 認領 在 GitHub 檢視
bug
主要語言
Java
星號
3.1k
分支
1.4k
平均合併
6 天 19 小時
30 天內合併 PR
32

描述

### problem

Is the global value of oauth2.plugins referenced or enforced anywhere in the code ?

### versions

ACS 4.22
ACS 4.23 rc 2

### The steps to reproduce the bug

oauth2.plugins (default "google,github", described as "List of OAuth plugins") is declared but is it used anywhere for validation ation.

Actual provider availability is determined entirely by which Spring beans exist (GoogleOAuth2Provider, GithubOAuth2Provider, hardcoded in the XML) plus oauth2.plugins.exclude (see Issue #2) and a different key, user.oauth2.providers.order, for ordering.

Steps to Reproduce:
1. cmk list configurations name=oauth2.plugins — shows google,github.
2. cmk update configuration name=oauth2.plugins value=github,keycloak

3. Attempt OAuth2 login with provider=google.

### What to do about it?

Expected: GitHub provider no longer available, per the setting's name and description.
Actual: No error on update, but github remains fully registered and functional — the change is a complete no-op.

Suggested fix: Either wire oauth2.plugins to genuinely gate provider registration, or remove it — as-is it presents a non-functional control surface that could lead an admin to believe they've disabled a provider when they haven't.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。