apache / apache/cloudstack

importVm (shared/local storage adoption): ROOT volume always gets deviceId 1, not 0

Aberta Para iniciantes
#13,771 4 comentários 0 reações 0 responsáveis Ver no GitHub
component:kvm component:managed-storage Severity:Minor type:bug
Linguagem predominante
Java
Estrelas
3.1k
Forks
1.4k
Merge médio
6d 19h
PRs com merge (30d)
32

Descrição

## Description

When adopting an existing disk with `importVm importsource=shared` or `importsource=local`, the ROOT
volume ends up with `deviceid=1` instead of `0`. This happens no matter which storage backend is used —
I saw it with RBD, Linstor, and plain qcow2 on NFS, all the same way.

It doesn't stop the VM from working. It boots fine, the disk is correct, everything else is normal. But
`deviceid=1` for a ROOT volume is unexpected, and any code (or person reading `listVolumes` output) that
assumes ROOT = device 0 will get confused here.

## Where it comes from

`server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java`, in the method that handles
the shared/local KVM import:

```java
long deviceId = 1L;
if (ImportSource.SHARED == importSource) {
diskProfileStoragePoolList.add(importKVMSharedDisk(userVm, diskOffering, Volume.Type.ROOT,
template, deviceId, poolId, diskPath, diskProfile));
} else if (ImportSource.LOCAL == importSource) {
diskProfileStoragePoolList.add(importKVMLocalDisk(userVm, diskOffering, Volume.Type.ROOT,
template, deviceId, hostId, diskPath, diskProfile));
}
```

`deviceId = 1L` is passed straight into the ROOT volume's own import call.

Compare this to the other two import paths in the same file (external/VMware import and staged import).
Both of those do it the right way: ROOT is imported with `deviceId=null` (which defaults to 0), and only
the loop that comes *after*, for data disks, starts counting at `deviceId = 1L`.

In the shared/local path there is no data-disk loop at all right now (data disks aren't imported this
way yet), so it looks like the `1L` that was meant for "first disk after ROOT" ended up being used for
ROOT itself by mistake.

## History

This is not new. `git log -S "importKVMSharedDisk"` traces it back to the original "KVM Ingestion -
Import Instance" PR (#7976), so it's been there since shared/local KVM import was first added.

## Suggested fix

Pass `null` (or `0`) as the deviceId for the ROOT volume in `importKVMSharedDisk` /
`importKVMLocalDisk`, the same way the external/VMware import path already does it.

## Reproduce

```
importVm importsource=shared hypervisor=KVM storageid= diskpath= networkid= ...
```

Then check `listVolumes` for the resulting VM — ROOT shows `deviceid: 1`.

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Comece em server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java e inspecione o método de importação KVM compartilhado/local, especialmente o deviceId passado para importKVMSharedDisk e importKVMLocalDisk. Compare os caminhos de importação external/VMware e staged e, em seguida, verifique se um volume ROOT importado informa deviceid 0, enquanto o comportamento de importação existente permanece inalterado.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
java
Domínio
infrastructure
Tipo de issue
Bug
Dificuldade
1/5
Tempo estimado
1-3 horas
Status de atividade
Ativa
Clareza
Claramente especificada
Facilidade para iniciantes
86/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.