apache / apache/cloudstack

Error tying to register ISO/Template with DirectDownload over HTTPS with Let's Encrypt

未关闭
#12,878 2 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
component:kvm component:templates no-issue-activity
主要语言
Java
星标
3.1k
派生
1.4k
平均合并
6 天 19 小时
30 天内合并 PR
32

描述

### problem

When using the "Direct Download" feature for an ISO or Template (bypassing Secondary Storage), the Agent fails to verify Let's Encrypt certificates due to the absence of Let's Encrypt’s main CA certificate.

> Note: Let's Encrypt is widely used on the internet (>50% of all certificates).

ACS currently loads and trusts certificates exclusively from `/etc/cloudstack/agent/cloud.jks` and does not fall back to Java (`/usr/lib/jvm/java-17-openjdk-amd64/lib/security/cacerts`) or the system store (`/etc/ssl/certs/ca-certificates.crt`). Both of these contain the missing certificate (**ISRG Root X1**), which has been in use since 2015.

See: https://letsencrypt.org/certificates/

Image

**ISRG Root X1** is the current root of the trust chain (valid until 2030), after which it will be replaced by **ISRG Root X2**.

**Recommendation:** Add a fallback to Java’s trust store to avoid maintaining an ever-changing list of certificates.

**Alternative:** As a short-term fix, include the missing CA certificate (https://letsencrypt.org/certs/isrgrootx1.pem) in `/etc/cloudstack/agent/cloud.jks` for the next release, while a more sustainable solution is developed.

### versions

We are running ACS 4.20.2 on Ubuntu 24.04. However, this issue likely affects all versions starting from 4.19, when the feature to bypass Secondary Storage was introduced.

Related issues and PRs:
- https://github.com/apache/cloudstack/issues/7929
- https://github.com/apache/cloudstack/pull/7693/changes
- https://github.com/apache/cloudstack/pull/7923/changes
- https://github.com/apache/cloudstack/pull/7932/changes
- https://github.com/apache/cloudstack/pull/11113/changes

### The steps to reproduce the bug

1. When registering an ISO or Template for Direct Download, use any HTTPS URL whose TLS certificate is issued by Let's Encrypt.

### What to do about it?

As a workaround, the following command can be run for each Zone to add the missing certificate. Note that this introduces additional manual steps for platform maintenance:

```
cmk upload templatedirectdownloadcertificate hypervisor="KVM" name="isrg-root-x1-2" certific
ate="$(curl -s https://letsencrypt.org/certs/isrgrootx1.pem)" zoneid="00000000-0000-0000-00000-000000000000"
```

贡献指南

打开贡献指南

调研方向

从 Agent 的证书处理和 `/etc/cloudstack/agent/cloud.jks` 入手,然后将其与 Java 的 `/usr/lib/jvm/java-17-openjdk-amd64/lib/security/cacerts` 以及位于 `/etc/ssl/certs/ca-certificates.crt` 的系统存储进行比较。使用 Let's Encrypt,针对 HTTPS URL 复现 ISO 或 Template 的直接下载,并考虑相关的 issue 和 PR;完成的标准是 Agent 无需针对每个 Zone 进行手动 workaround 即可验证证书。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
backend, cloud, infrastructure
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
48/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。