apache / apache/cloudstack

Validate and don't allow the api createVMFromBackup for cks clusters

未關閉
#12,840 1 則留言 0 個 reaction 已指派 1 人 已被 @nvazquez 認領 在 GitHub 檢視
component:cks no-issue-activity
主要語言
Java
星號
3.1k
分支
1.4k
平均合併
6 天 19 小時
30 天內合併 PR
32

描述

### problem

https://cloudstack.apache.org/api/apidocs-4.22/apis/createVMFromBackup.html

### versions

ACS 4.22

### The steps to reproduce the bug

1. Launch a cks cluster with 2 worker node with default system template

2. CKS cluster in running state

3. Navigate to the instance > worker node > Assign a backup offering to the worker node

4. Create a back up for the worker node

5. Try to create vm from backup

https://cloudstack.apache.org/api/apidocs-4.22/apis/createVMFromBackup.html

Error thrown by cloudstack saying that systemvm template cannot be used to launch a vm

Image

4. CKS cluster goes into alert state

Second Scenario

1. Launch a cks cluster with 2 worker node with default system template

2. CKS cluster in running state

3. Launch a vm external vm with cks ubuntu template

https://download.cloudstack.org/testing/custom_templates/ubuntu/22.04/

4. Add the external node to the cks cluster

5. External node added successfully > Cks cluster in running state

6. Create a back up for the external worker node

7. Try to create vm from the external node backup

https://cloudstack.apache.org/api/apidocs-4.22/apis/createVMFromBackup.html

8. Back up vm created since its a ubuntu template

9. Try to re add the external backup vm

10. CKS cluster struck in the importing state

Image
Image

...

### What to do about it?

Cloudstack should not allow to create vm from backup for vm's which are part of cks cluster

https://cloudstack.apache.org/api/apidocs-4.22/apis/createVMFromBackup.html

Currently creating a backup and restoring a back for cks node is working fine

An exception message should be thrown

Similar to the pr

https://github.com/apache/cloudstack/pull/12800

Or

Don't allow the addition of external vm to the cks cluster if the vm is created from a backup

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。