apache / apache/cloudstack

Ldap imported accounts which are saml enabled doesn't fallback to ldap if saml is disabled

Open
#12,595 1 comment 0 reactions 0 assignees View on GitHub
component:LDAP component:saml
Dominant language
Java
Stars
3.1k
Forks
1.4k
Avg merge
6d 19h
Merged PRs (30d)
32

Description

### problem

Ldap imported accounts which are saml enabled doesn't fallback to ldap if saml is disabled

### versions

ACS 4.23 Nightly

### The steps to reproduce the bug

1. Configure a LDAP and Import a LDAP account

Image

2. Check the user type , its set to LDAP

Image

3. Authorize SAML to the imported ldap account

Image

4. The user type is assigned as SAML

Image

5. Disable SAML SSO

Image

6. The user type is assigned as NATIVE TYPE

Image

7. The LDAP imported user is not able to login with LDAP credentials since the user type changes

made sure the setting

enable.login.with.disabled.saml is set to true

https://github.com/apache/cloudstack/pull/10868

### What to do about it?

If the SAML authentication is disabled for a LDAP imported account.

The user type should switch back to LDAP

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the LDAP import, SAML authorization, SAML disablement, and LDAP login steps described in the issue, then read the behavior changed in PR #10868. Trace where the account user type is changed when SAML is disabled. Done means the account returns to LDAP user type and can authenticate with LDAP credentials while the stated setting is enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.