apache / apache/arrow

[C++][SIMD] Avoid one-definition-rule violation of `arrow::internal::BitmapWriter` without depending on `-O2`

Offen
#36,902 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Component: C++ Type: enhancement
Vorherrschende Sprache
C++
Sterne
17.1k
Forks
4.3k
Ø Merge
3 T. 18 Std.
Gemergte PRs (30 T.)
91

Beschreibung

### Describe the enhancement requested

Contexts:

* https://github.com/apache/arrow/issues/31132#issuecomment-1378082076
* GH-14342
* GH-36685

We have runtime SIMD dispatch feature. For example, it's used in `cpp/src/parquet/level_conversion.cc` to run BMI2 based `DefLevelsToBitmap` implementation if available.

`DefLevelsToBitmap` (`DefLevelsToBitmapSimd`) is implemented in `cpp/src/parquet/level_conversion_inc.h` and it's built with/without BMI2. `DefLevelsToBitmapSimd` uses `arrow::internal::BitmapWriter`. If `arrow::internal::BitmapWriter` in `DefLevelsToBitmapSimd` is not inlined, one-definition-rule violation is happen. If it's happen, `libparquet.dylib` has two `BitmapWriter` definitions for with/without BMI2. If BMI2 version `BitmapWriter` is used on BMI2 unavailable machine, "illegal opcode" is happen.

GH-14342 resolved this by forcing to use `-O2` to enforce inlining. But it doesn't work with Homebrew. Because Homebrew overrides `-O*` specified by us.

If we can avoid one-definition-rule violation of `arrow::internal::BitmapWriter` without depending on `-O2`, we can provide a Homebrew bottle that can use the BMI2 based implementation on machines that support BMI2.

### Component(s)

C++

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with cpp/src/parquet/level_conversion.cc and cpp/src/parquet/level_conversion_inc.h, focusing on DefLevelsToBitmap, DefLevelsToBitmapSimd, and their use of arrow::internal::BitmapWriter. Check how the BMI2 and non-BMI2 variants are built and dispatched. Done means avoiding duplicate BitmapWriter definitions and illegal opcodes without depending on -O2, including for Homebrew builds.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
cpp
Bereich
build-system, performance
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.