apache / apache/arrow-java

[Java] Avro to Arrow converter should reuse the same VectorSchemaRoot

Open
#328 1 comment 0 reactions 0 assignees View on GitHub
Type: enhancement
Dominant language
Java
Stars
94
Forks
152
Avg merge
3d 16h
Merged PRs (30d)
11

Description

When originally reviewing the code I suggested a new VectorSchemaRoot on each call to the iterator.  After further discussions on the mailing list, it seems that this is an anit-pattern for working with VectorSchemaRoot, we should update the code to update a single VectorSchemaRoot.

 

After this change it should be easier to use Avro converter with other components of the library (i.e. filewriter) which also make use of a single VectorSchemaRoot.

**Reporter**: [Micah Kornfield](https://issues.apache.org/jira/browse/ARROW-9613) / @emkornfield

**Note**: *This issue was originally created as [ARROW-9613](https://issues.apache.org/jira/browse/ARROW-9613). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

Contributor guide

Open the contributing guide

Research direction

Start by locating the Java Avro converter and its iterator, then read how VectorSchemaRoot is created and returned on each call. The change is done when the converter updates and reuses one VectorSchemaRoot, allowing it to work with components such as the filewriter; run the converter’s existing tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.