apache / apache/arrow-java

[JDBC] Honor DriverManager login timeout

未关闭
#1,268 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Java
星标
94
派生
152
平均合并
3 天 16 小时
30 天内合并 PR
11

描述

### Describe the enhancement requested

`ArrowFlightJdbcDriver.connect()` does not currently honor the timeout configured through `DriverManager.setLoginTimeout(int)`.

Implement support for the `DriverManager` login timeout:

- Read the value exposed by `DriverManager.getLoginTimeout()` when establishing a connection selected by `DriverManager`.
- Preserve the JDBC semantics of zero: do not impose a login timeout.
- Apply a nonzero timeout to the overall connection attempt, not only the underlying Netty socket connection.
- If the timeout expires, attempt to cancel the connection attempt and throw `SQLTimeoutException`.
- Clean up any allocator, channel, or partially constructed client when the attempt is cancelled or times out.
- Add tests that set and restore the global `DriverManager` timeout and verify timeout enforcement, exception type, and resource cleanup.

This is distinct from #494/#495. The existing `connectTimeoutMs` property configures Netty socket connection attempts and does not consume the timeout configured through `DriverManager`.

Context: #1027 and [the follow-up discussion](https://github.com/apache/arrow-java/pull/1027#issuecomment-5447203124).

Related DataSource work: https://github.com/apache/arrow-java/issues/1267

贡献指南

打开贡献指南

调研方向

入口点是 ArrowFlightJdbcDriver.connect(); 首先阅读其当前的连接路径以及现有的 connectTimeoutMs 处理。添加覆盖,设置并恢复 DriverManager 的全局超时,检查超时为零和非零时的行为、SQLTimeoutException,以及整个尝试被取消或超时时 allocator、channel 和 client 的清理情况。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
backend, database
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
55/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。