apache / apache/arrow-java

[JDBC] Implement DataSource login timeout

Aperta
#1,267 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
94
Fork
152
Merge medio
3g 16h
PR unite (30g)
11

Descrizione

### Describe the enhancement requested

`ArrowFlightJdbcDataSource.setLoginTimeout(int)` currently throws `SQLFeatureNotSupportedException`, and `getLoginTimeout()` always returns `0`.

Implement the JDBC `DataSource` login-timeout contract:

- Store and return the timeout configured for each `ArrowFlightJdbcDataSource` instance.
- Apply a nonzero timeout to connection establishment through `DataSource.getConnection()`.
- Preserve the JDBC semantics of zero: use the default system timeout if one exists; otherwise, do not impose a timeout.
- If the timeout expires, attempt to cancel the connection attempt and throw `SQLTimeoutException`.
- Clean up any allocator, channel, or partially constructed client when the attempt is cancelled or times out.
- Add tests for the default value, setter/getter behavior, timeout enforcement, exception type, and resource cleanup.

This is distinct from #494/#495. The existing `connectTimeoutMs` property configures Netty socket connection attempts; the JDBC login timeout applies to the overall database connection attempt exposed by `DataSource.getConnection()`.

Context: #1027 and [the follow-up discussion](https://github.com/apache/arrow-java/pull/1027#issuecomment-5447203124).

Related DriverManager work: https://github.com/apache/arrow-java/issues/1268

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with ArrowFlightJdbcDataSource.setLoginTimeout(int), getLoginTimeout(), and the DataSource.getConnection() path; compare them with the existing connectTimeoutMs behavior. Add coverage for the default, setter/getter, timeout enforcement, SQLTimeoutException, and cleanup of partially created resources. Done means zero preserves default behavior and nonzero login timeouts cancel failed attempts without leaks.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
databases
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
66/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.