apache / apache/arrow-java

Managing ownership in VectorSchemaRoot#addVector, recent changes miss the main fault.

未关闭
#1,142 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Type: bug
主要语言
Java
星标
94
派生
152
平均合并
3 天 16 小时
30 天内合并 PR
11

描述

A recent change in VectorSchemaRoot#addVector provided a simple improvement, but completely misses a major shortcoming of this routine and, almost certainly, others like it. Based on the interest in that issue (#301), this issue might be of interest to @axreldable and @jbonofre.

One cannot change the `FieldVector`s belonging to `VectorSchemaRoot`s by simply rearranging the elements of their `List`s without considering the ownership of their underlying buffers. This can cause various problems, particularly when `VectorSchemaRoot`s are closed. This is why `TransferPair` exists.

I would probably need some help with improving this as I'm quite new to using Apache Arrow (and very new to using GitHub). But I have written a possibly improved implementation if this would be of interest and would be open to collaborating on rectifying this bug.

贡献指南

打开贡献指南

调研方向

从 VectorSchemaRoot#addVector 开始,并阅读 issue #301 中的相关讨论。调查重新排列 FieldVectors 如何影响其底层缓冲区的所有权,以及 VectorSchemaRoots 在关闭时的行为。完成的标准是正确处理所有权转移,并且关闭 roots 不再导致所描述的缓冲区问题。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
data
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
需要澄清
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。