antonio-ramadas / antonio-ramadas/palbum

Refactor App.js

未關閉
#7 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
frontend good first issue
主要語言
JavaScript
星號
9
分支
0
PR 合併指標
30 天內沒有已合併 PR

描述

[App.js](https://github.com/antonio-ramadas/palbum/blob/master/src/App.js) is doing more than it should. It populates the page (search bar and table).

However, whenever there is an update to the list (e.g., a new album is added) the whole component is rendered. As you can guess, there is no need for it.

Also, with a refactor, the logic would no longer be on a single file and its size will most likely be reduced.

I suggest having one component for the search bar, another for the table and App.js simply calls them on the `render`method.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。