antirez / antirez/rax

valgrind complains about uninitialized memory

Open
#14 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
1.3k
Forks
177
PR merge metrics
No merged PRs in 30d

Description

The nodes are allocated with malloc and often not initialized.
I'm not sure that it's a real problem, but perhaps it's better to use calloc instead of malloc.
```patch
diff --git a/app/jni/rax_malloc.h b/app/jni/rax_malloc.h
index e9d5d5d7b..2ebe00665 100755
--- a/app/jni/rax_malloc.h
+++ b/app/jni/rax_malloc.h
@@ -37,7 +37,7 @@

#ifndef RAX_ALLOC_H
#define RAX_ALLOC_H
-#define rax_malloc malloc
+#define rax_malloc(s) calloc(1, s)
#define rax_realloc realloc
#define rax_free free
#endif
```

If you want I can create a PR.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.