antirez / antirez/lua-cmsgpack
mp_buf_append and sanitizing realloc
- Lenguaje dominante
- C
- Estrellas
- 383
- Forks
- 122
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
I noticed mp_buf_append and mp_buf_new are not sanitizing the result to [mp_realloc](https://github.com/antirez/lua-cmsgpack/blob/master/lua_cmsgpack.c#L122).
The Lua documentation states that when the pointer is non-null is must behave like realloc (and in the default case it is: `return realloc(ptr, nsize)`). In turn, when realloc fails the original block is left untouched and NULL is returned, which paths into a memcpy (and likely segmenta.... fau.. or something else entirely dependent on `buf->len`).
While a minor issue, a bit of defensive programming here would not hurt.
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Evaluación
Este issue todavía no se ha evaluado.