antirez / antirez/hping

Wrong byte order in the sequence number of ICMP echo requests (Little Endian)

Open
#19 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
1.7k
Forks
364
PR merge metrics
No merged PRs in 30d

Description

In sendicmp.c the sequence number header field of ICMP echo requests is set to _icmp_seq which is a counter. However in little-endian architectures (x86) we need to change the byte order to big-endian so that it meets the network order convention. We can use htons(_icmp_seq) for this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.