antirez / antirez/RESP3

Idea: backwards compatible way to drop the CR

Offen
#39 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Keine Sprachdaten
Sterne
230
Forks
41
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

What if the initial `HELLO` message could either end with CRLF or just a single LF, and which one is used determines wether the rest of the connection will use CRLF or LF as a line break. This way clients could continue using CRLF if that is simpler, or switch to just using LF with RESP3 if desired. The biggest downside is that it makes the server code slightly more complicated, and such functionality would probably only be used by RESP3-only clients.

I'm not saying this should necessarily be done, but if removing the unnecessary carriage return is desirable, this could be a way to do it.

> All in all the saving of one byte did not made enough sense in light of a more complex client implementation

I'm curious if there is any data on what the actual overhead of the carriage return is on real-world connections. If the bulk of messages are sufficiently small, one byte could make a difference.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.