anthropics / anthropics/claude-code-action

No way to test review before merging

Aperta
#881 1 commento 4 reazioni 0 assegnatari Vedi su GitHub
dev-experience enhancement p3
Lingua principale
TypeScript
Stelle
8.9k
Fork
2.1k
Merge medio
3g 9h
PR unite (30g)
10

Descrizione

Related: #722

The workflow intentionally fails if the file is different from the contents on the target branch (e.g. `main`). That's a good security feature, but it makes it very difficult to test changes to the review workflow:

1. open PR 1 to change the review workflow
2. merge PR 1
3. open PR 2 to test the review workflow; workflow fails
4. open PR 3 to fix the review workflow
5. merge PR 3
6. rebase PR 2 on target branch, ...

I wonder whether there's a secure way to offer an override. Some un-vetted ideas:

- Allow users to set a GitHub environment variable to the SHA of the commit you want to allow.
- Allow a list of workflow maintainers (GitHub user IDs or groups). It's important that this be sourced from the workflow definition on the target branch.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.