anthropics / anthropics/buffa

Allow passing descriptor_set as bytes instead of a file path

Aperta
#407 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
883
Fork
88
Merge medio
3g 19h
PR unite (30g)
42

Descrizione

Currently, buffa-build allows passing a descriptor_set to use instead of proto files

https://github.com/anthropics/buffa/blob/ccc9adddb51274a45a0155d40514137504904140/buffa-build/src/lib.rs#L1640

This is then just read into bytes

https://github.com/anthropics/buffa/blob/ccc9adddb51274a45a0155d40514137504904140/buffa-build/src/lib.rs#L1772

It would be great if bytes could be passed directly for when the build script can prepare them, for example using protox. Perhaps changing `Precompiled` to hold a `Vec` and have the parameter accept either a sealed trait that is implemented for both `Path` and `&[u8]`, or if breaking is ok, just accept the slice only since reading a path (as buffa-build currently does) wouldn't be that hard for a user.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.