anthropics / anthropics/buffa

Allow passing descriptor_set as bytes instead of a file path

Open
#407 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
883
Forks
88
Avg merge
3d 19h
Merged PRs (30d)
42

Description

Currently, buffa-build allows passing a descriptor_set to use instead of proto files

https://github.com/anthropics/buffa/blob/ccc9adddb51274a45a0155d40514137504904140/buffa-build/src/lib.rs#L1640

This is then just read into bytes

https://github.com/anthropics/buffa/blob/ccc9adddb51274a45a0155d40514137504904140/buffa-build/src/lib.rs#L1772

It would be great if bytes could be passed directly for when the build script can prepare them, for example using protox. Perhaps changing `Precompiled` to hold a `Vec` and have the parameter accept either a sealed trait that is implemented for both `Path` and `&[u8]`, or if breaking is ok, just accept the slice only since reading a path (as buffa-build currently does) wouldn't be that hard for a user.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.