anomaly / anomaly/lab-python-server

Building Custom Comparator for SQLAlchemy for the password property

Open
#51 2 comments 0 reactions 1 assignee Claimed by @devraj View on GitHub
Dominant language
Python
Stars
16
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Extending from the pattern that allows developers to simply set the `password` property and a setter hashes it on the way in. The `User` model class has substantial documentation on this. The general approach is to declare the property as:

```python
_password = Column("password",
String,
nullable=True)
```

followed by exposing the `password` property as:

```python
@property
def password(self):
return self._password
```

and finally overriding the setter to `hash` the password on the way in:
```python
@password.setter
def password(self, password):
self._password = hash_password(password)
```

The [Building Custom Comparator](https://docs.sqlalchemy.org/en/14/orm/extensions/hybrid.html#building-custom-comparators) guide outlines how we can override the comparator of `hybrid_property` in `SQLAlchemy`, if we adopt this paradigm then we can achieve comparing password as:

```python
user.password == password
```

as opposed using `check_password` method

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.