ankidroid / ankidroid/Anki-Android

Review reminders: migration

Open
#21,755 6 comments 0 reactions 1 assignee Claimed by @ericli3690 View on GitHub
Advanced Reminders
Dominant language
Kotlin
Stars
11.8k
Forks
2.9k
Avg merge
2d 3h
Merged PRs (30d)
171

Description

How do we want to perform the migration from the old notification system to the new review reminders? How fast should the switch-over be? Do we want it to be opt-in / simply increase the visibility of the feature flag for a few weeks? Do we just unilaterally migrate everyone from the old system the the new one in a single update, and ensure that we test it properly in alpha and beta?

We should create some migration code that detects if the old notification settings are on (via `PreferenceUpgradeService`). For example, if "Notify when: more than 10 cards due" is selected, then a review reminder for all decks with a card trigger threshold of 10 should be created when the app is loaded up with the new update for the first time. We can ignore migrating the old `vibrate` and `blink light` settings, as we've decided to let the OS handle those.

Finally, we should delete the old legacy notifications code (anything annotated with `LegacyNotifications`, `NotificationFragment`, etc.).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.