ankidroid / ankidroid/Anki-Android

multimodule support: move strings to `:common:android`

Abierto
#21,500 3 comentarios 0 reacciones 1 asignado Reclamado por @david-allison Ver en GitHub
Lenguaje dominante
Kotlin
Estrellas
11.8k
Forks
2.9k
Merge medio
2 d 3 h
PR fusionados (30 d)
171

Descripción

> **Strings**: move all into `:common:android`.
>
> This unblocks us simply/quickly and allows a future discussion about the CrowdIn sync/file architecture.
>
> ----
>
> Medium-term: I think `:widgets` containing strings will be a "Won't fix" for a while
>
> Architecturally, strings should live in their modules, but I think moving strings up into `:widgets` would:
> * Mildly improve `R.string` via namespacing
> * Produce minimal performance gains (the resources would still need to be bundled inside the app).
> * Not improve discoverability (developers know where the strings are)
> * Add disruption/infra complexity in the case that a string needs to be pulled up/down from `:widgets` into `common:android`
> * Also with lint & cross-module duplication checks
> * Not have any tangible benefit to translators
>
> I don't see the upsides being worth the time to update our translation infra for this.

_Originally posted by @david-allison in [#20737](https://github.com/ankidroid/Anki-Android/issues/20737#issuecomment-4303120972)_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.