ankidroid / ankidroid/Anki-Android

Improve tags dialog initialization speed

Open
#18,424 2 comments 0 reactions 0 assignees View on GitHub
Keep Open Performance
Dominant language
Kotlin
Stars
11.8k
Forks
2.9k
Avg merge
2d 3h
Merged PRs (30d)
171

Description

Follow-up issue after #16473 and #18297. When doing #18297 I took a look at some other potential points that could be improved.

Here are some ideas:

1. Uses `col.tags.tree()` to get the tag tree
2. Avoid creating new sets like TagsList do https://github.com/ankidroid/Anki-Android/blob/c620082338e5f7bb6e72ac5bbef55dca2bf0760d/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsList.kt#L58-L61
3. Avoid resorting the tags list https://github.com/ankidroid/Anki-Android/blob/c620082338e5f7bb6e72ac5bbef55dca2bf0760d/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsList.kt#L267

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.