ankidroid / ankidroid/Anki-Android

Shortcuts/share to ankidroid should not crash the app when the file permissions are missing

Đang mở
#16,786 14 bình luận 0 reaction 1 người được giao Được @criticalAY nhận Xem trên GitHub
Bug Keep Open Priority-Low
Ngôn ngữ chính
Kotlin
Star
11.8k
Fork
2.9k
Merge trung bình
2 ngày 3 giờ
Pull request đã merge (30 ngày)
171

Mô tả

How to reproduce:
* install ankidroid from a source that is not the playstore. If you build ankidroid yourself, you can use the full variant.
* open ankidroid, give permission to access file
* open the settings, go to apps > Special app access> all files access> ankidroid> toggle off "allow access to manage all files" (Or, you can wait a few months, android remove permissions to apps that are not used)
* Then, either:
* long tap ankidroid, and open the shortcut for study, add or card browser
* select some text, and share it with ankidroid, with note editor or instant note editor ( ping @criticalAY )
* select an image, and share it to ankidroid > Add Image

Actual result:
* You'll see a snackbar "Missinq required storage permission. Please grant storage permission then r..."

Expected result:
* same as when you open ankidroid directly, open a downloaded deck, or when you share an image to AnkiDroid > Image Occlusion, that is, opens a page that state
> Ankidroid needs some permission to work.

This is a very low priority bug, because it can only occurs to people who:
* don't use the play store version,
* have spent months without using ankidroid, have manually removed a permission, or try to share to ankidroid before opening ankidroid a first time normally
* have created shortcuts or decides to share images or text to ankidroid.

This probably happened to some of our users, but I expect this to be quite rare

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.