anitab-org / anitab-org/mentorship-backend

Make mentioned changes in resources files to follow the same convention

Open
#898 5 comments 0 reactions 1 assignee Claimed by @gitpurva View on GitHub
Category: Coding Status: On Hold
Dominant language
Python
Stars
200
Forks
449
PR merge metrics
No merged PRs in 30d

Description

## Description
As a contributor,
I need consistent style followed in resources file,
so that I don't get confused that whether some part of the code is missing or not.

## Mocks
https://github.com/anitab-org/mentorship-backend/blob/6fe6929fed2007ed43242f36c44f9bcca1d79979/app/api/resources/user.py#L171-L182
Here the route is below the responses which breaks the convention.
https://github.com/anitab-org/mentorship-backend/blob/6fe6929fed2007ed43242f36c44f9bcca1d79979/app/api/resources/user.py#L247-L268
Here the responses aren't attached with the route function but with the put().

## Acceptance Criteria
### Update [Required]
- [ ] Make the above mentioned changes in the code to follow the same convention throughout the file.
- [ ] Check the same with other resources files and fix them if such convetion is broken.

## Definition of Done
- [ ] All of the required items are completed.
- [ ] Approval by 1 mentor.

## Estimation
4 hours

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.