anitab-org / anitab-org/mentorship-backend

OSError in Windows not being caught

未关闭
#618 9 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Category: Coding Help Wanted Status: Available
主要语言
Python
星标
200
派生
449
PR 合并指标
30 天内没有已合并 PR

描述

**Describe the bug**

When there is some invalid argument, we expect it to be caught by python under ValueError.
But In the case of passing invalid timestamp in test `test_dao_create_mentorship_relation_with_good_args_but_invalid_timestamp`.
It get's caught on other OS, but for Windows It throws OSError (Another Exception) which is not getting caught by ValueError.

**To Reproduce**
(Steps for windows only)
1. Run python unittests (there should be one test failure)
2. See the error

**Expected behavior**
The test should pass and no test should have been failed.

**Screenshots**
![image](https://user-images.githubusercontent.com/18344707/83308851-5dd5be00-a225-11ea-8c70-cc82fea8692c.png)

**Desktop (please complete the following information):**
- OS: Windows

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。