anishathalye / anishathalye/periscope

Windows support

未關閉
#1 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
Go
星號
429
分支
16
PR 合併指標
30 天內沒有已合併 PR

描述

Periscope doesn't currently work on Windows. The tests also don't work -- the tests using [testfs](https://github.com/anishathalye/periscope/tree/master/testfs) (which relies on [afero](https://github.com/spf13/afero/)'s MemFs) seem to hang / OOM, and the tests using the real filesystem and fancy features like symlinks don't work either.

To support Windows, we need to, among other things:

- Adjust how we handle detecting the root directory (see https://github.com/anishathalye/periscope/issues/10#issuecomment-1367892986)
- Figure out why the MemFs-based tests aren't working, and fix them
- Figure out why tests using the real filesystem aren't working, and either split them into separate files that are only used on macOS/Linux, or figure out how to adapt them to be cross-platform
- Understand any potential subtleties of Periscope on Windows/NTFS, fix the code to handle these cases, and add Windows-specific tests

(I don't use Windows, so this is a low-priority issue for me. There's a good chance this will only be supported if someone can help out with this.)

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。