angular / angular/components

[Paginator] Does not emit event when changed programatically

Aperta
#8,417 23 commenti 26 reazioni 0 assegnatari Vedi su GitHub
area: material/paginator P3
Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 8h
PR unite (30g)
91

Descrizione

#### Bug, feature request, or proposal:

Bug

#### What is the expected behavior?

Changing the page index programmatically should emit a `page` event.

#### What is the current behavior?

Assigning to `.pageIndex` does not emit a `page` event. There is no method to jump to a specified page and ensure that an event is emitted.

#### What are the steps to reproduce?

Open [this plunker](https://embed.plnkr.co/dPr77Z/). Enter a (different) page number in the input at the top of the page and click "Go To". The displayed paginator offset ("11-20") changes but the table results do not.

#### What is the use-case or motivation for changing an existing behavior?

The current behavior is wrong. The documentation for the `page` Output says "Event emitted when the paginator changes the page size or page index"; the page index has changed but the event was not emitted.

#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Still happening as of Beta 12, at least.

#### Is there anything else we should know?

I checked [paginator.ts](https://github.com/angular/material2/blob/master/src/lib/paginator/paginator.ts) and the event is emitted in various methods that change the page index (next / previous) but not in the setting for pageIndex itself. I don't know why this design decision was made so I hesitate to suggest that it be changed, but we need *some* way to tell the paginator to go to a page as though the user had clicked to get to that page.

In the short term, I noticed that the private method `_changePageSize` is exposed in the typings for this component, and does not check if the size being set is the current size. So I can call

this.paginator._changePageSize(this.paginator.pageSize);

to force the paginator to emit a `page` event. Of course it's a pretty awful hack, but it gets the intended behavior. It'd be nice to avoid this in a future release.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia da src/lib/paginator/paginator.ts, dove viene emesso il page event per i cambiamenti alla pagina successiva e precedente, e riproduci il problema usando il Plunker collegato. Traccia il pageIndex setter e il comportamento correlato del paginator; il lavoro sarà completo quando i cambiamenti di pagina programmatici emetteranno il page event, in modo che i risultati della tabella che li utilizza vengano aggiornati in modo coerente.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
frontend
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.