Autocomplete slow to update with large data sets after material beta 12
- Lenguaje dominante
- TypeScript
- Estrellas
- 25k
- Forks
- 6.8k
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 91
Descripción
#### Bug, feature request, or proposal:
When displaying an autocomplete list with a large number of options it is slow to display. It appears that this is caused by 2 event listeners being created for each item in the list. This slowness started after updating to beta 12.
You can see the large number of event listeners being set up if you open the Chrome dev tools and set the logging level to verbose.
`[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952`
#### What is the expected behavior?
Similar performance when using autocomplete with 200+ data sets to older versions of material.
#### What is the current behavior?
Rendering an autocomplete with a large number of options has a delay, it is even longer when the dev tools are open due to the large number of event listeners being created causing logs to be written to the console
#### What are the steps to reproduce?
Open dev tools, set console logging to verbose and click the "Click to toggle autocomplete" button .
You can also see the behavior by filtering the list, type anything to shorten the length of the list, then clear the input and new event listeners will be created again for each item in the list causing additional slowdown.
https://plnkr.co/edit/QhlHy7FrlvQbDeRfncCo?p=preview
#### What is the use-case or motivation for changing an existing behavior?
Improve performance. Is it not possible to have a single event listener on the parent that catches click events that bubble up? If not do 2 event listeners need to be created for each item in the list?
#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular: 4.4.4
Material: beta.12
All browsers
#### Is there anything else we should know?
Event handler times on beta.11
Clearing out the input box, causing all items to be displayed again
`[Violation] 'input' handler took 187ms`
Clicking the button to display the autocomplete
`[Violation] 'click' handler took 246ms`
Event handler times on beta.12 doing the same actions
`[Violation] 'input' handler took 1347ms`
`[Violation] 'click' handler took 1048ms`
Guía de contribución
Línea de trabajo
Comienza con la reproducción de Autocomplete en el Plunker enlazado y usa el registro detallado de Chrome DevTools para comparar beta.12 con beta.11. Rastrea la creación de listeners al abrir, filtrar y borrar la lista; se considerará terminado cuando los conjuntos grandes de opciones ya no sufran el retraso relacionado con los listeners indicado y los tiempos de los event handlers sean comparables a los de la versión anterior.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- angular, typescript
- Área
- frontend, performance
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100