angular / angular/components

[Table] Add inline editing for inputs

Open
#5,982 34 comments 189 reactions 0 assignees View on GitHub
area: material/table feature P4
Dominant language
TypeScript
Stars
25k
Forks
6.8k
Avg merge
1d 8h
Merged PRs (30d)
91

Description

#### Bug, feature request, or proposal:

Feature request

#### What is the expected behavior?

Clicking on a text field should launch a simple edit dialog with an `md-input`. Hitting Enter would then close the dialog and save the input as the new value for the text field.

#### What is the use-case or motivation for changing an existing behavior?

This behavior is described in the Data Table section of the Material spec, found [here](https://material.io/guidelines/components/data-tables.html#data-tables-interaction), and would be useful to have as its own component.

#### Is there anything else we should know?

Accessibility is a real concern here, and there doesn't seem to be much discussion/affordance defined in the spec for possible solutions. The text field itself could be defined as a button with `aria-role="button"`, but that may be deceptive.

cc @andrewseguin @jelbourn

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the requested interaction and the linked Material data-table specification. Resolve the accessibility approach before identifying the relevant table and input entry points; done means text fields open an edit dialog, Enter saves the new value and closes it, and the interaction is accessible.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.