angular / angular/components

Bug in table.scss footer cell height: unset instead of footer row height unset

Offen Anfängerfreundlich
#33,709 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
area: material/table gemini-triaged P4
Vorherrschende Sprache
TypeScript
Sterne
25k
Forks
6.8k
Ø Merge
1 T. 8 Std.
Gemergte PRs (30 T.)
91

Beschreibung

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

`// Flex rows should not set a definite height, but instead stretch to the height of their
// children. Otherwise, the cells grow larger than the row and the layout breaks.
.mat-mdc-table mat-header-row.mat-mdc-header-row,
.mat-mdc-table mat-row.mat-mdc-row,
.mat-mdc-table mat-footer-row.mat-mdc-footer-cell {
height: unset;
}`
https://github.com/angular/components/blob/main/src/material/table/table.scss#L158

Is `mat-mdc-footer-cell` intentional?
I feel it must be `mat-mdc-footer-row` not `cell

### Reproduction

StackBlitz link: https://stackblitz.com/edit/ydyoaqxm
Steps to reproduce:
1. npm run start
2. check 1 and 2 tables (wrong). check 3rd table fixed by tokens (okay)

### Expected Behavior

mat-mdc-footer-row height unset

### Actual Behavior

mat-mdc-footer-cell height unset

### Environment

- Angular: v18.2.4
- CDK/Material: v18.2.4
- Browser(s): 151.0.7922.172
- Operating System (e.g. Windows, macOS, Ubuntu): windows

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Open src/material/table/table.scss around line 158 and compare the footer selector with the reported expected behavior. Run the linked StackBlitz reproduction or the listed npm run start steps, then verify that the footer row rather than a footer cell has an unset height and the affected tables no longer break.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
angular, scss
Bereich
frontend
Issue-Typ
Bug
Schwierigkeit
1/5
Geschätzter Aufwand
Unter einer Stunde
Aktivitätsstatus
Aktiv
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
88/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.