angular / angular/components

bug(Schematics): Modernize schematics

Aperta
#33,460 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
area: ng-generate gemini-triaged P3
Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 8h
PR unite (30g)
91

Descrizione

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

I opened an Issue for modernizing the Navigation schematic: https://github.com/angular/components/issues/33381. I have since observed that all the other [schematics](https://material.angular.dev/guide/schematics) generate code with similar issues, so I am opening this Issue for improving and modernizing the code generated by the rest of the schematics, namely:

- [ ] 1. `address-form`
- [ ] 2. `dashboard`
- [ ] 3. `table`
- [ ] 4. `tree`

These are the issues I have observed:

1. The code includes M2 APIs that are no longer relevant. E.g., `address-form` generates a button with `color="primary"`, and `table` generates a table with `mat-elevation-z2`.
2. The code includes Reactive Forms (e.g., `address-form`). This should be replaced with Signal Forms, or a command line argument needs to be provided to indicate Signal Forms.
3. The `tree` schematic generates code that is based on deprecated modules: `MatTreeFlatDataSource`, `MatTreeFlattener`, and `FlatTreeControl`. Moreover, in the template, there is an empty button ``. The icon is incorrectly placed after the button rather than within it.

### Reproduction

This issue does not require a StackBlitz reproduction because these are comments on the code generated by the schematics.

### Expected Behavior

The schematics should produce quality code and set the standard for implementing Material Design components.

### Actual Behavior

The code has several issues.

### Environment

Angular CLI : 22.0.1
Angular : 22.0.1
Node.js : 26.1.0
Package Manager : npm 11.16.0
Operating System : win32 x64
Browser: Chrome

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia con l’issue 33381 di Navigation schematic e la guida degli schematics, quindi esamina l’output generato per address-form, dashboard, table e tree. Confronta le API, i form e i template generati con le indicazioni attuali di Angular Material; il lavoro è completato quando tutti e quattro gli schematics generano codice moderno e di qualità senza i pattern deprecati o posizionati in modo errato elencati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
tooling
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.