angular / angular/components

bug(COMPONENT): Font Awesome Icons have styling problems when a mat-button is on the page

Aperta
#32,338 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
area: material/button P2
Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 8h
PR unite (30g)
91

Descrizione

### Is this a regression?

- [x] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

19.2.8

### Description

Material buttons cause styling for mat-icon-buttons containing font awesome icons in safari and chrome

### Reproduction

StackBlitz link: https://stackblitz.com/edit/stackblitz-starters-ga6nsxqe?file=src%2Fmain.ts,angular.json,src%2Fglobal_styles.css
Steps to reproduce:
1. Clicking any of the red icon buttons will toggle a variable that controls whether the mat-button is in the DOM. To view the problem make sure the button is toggled visible.

### Expected Behavior

Icons will remain the same size and stay visible weather there is a material button in the DOM or not

### Actual Behavior

In Chrome: Some of the taller font awesome icons will be extra tall when a button is in the DOM and be the correct size when there are no buttons in the DOM. Forcing sizes with css classes or direct styles does not impact the height of the icon when the material button is in the DOM. Note that fa-building and fa-play are two examples of taller font awesome icons while fa-toolbox is normal size. In Chrome fa-toolbox behaves how it should when the material button is in the DOM.

Here is what it looks like when the button is toggled into the DOM in chrome:
Image

Here is what it looks like when the button is toggled out of the DOM in chrome:

Image

In Safari: All of the font awesome icons disappear entirely when the button is in the DOM

Here is what it looks like when the button is toggled into the DOM in safari:

Image

Here is what it looks like when the button is toggled out of the DOM in safari

Image

Note the fourth icon is visible in safari, this is a normal home icon from material icons and I included it for reference. The other three (fa-building, fa-play, and fa-toolbox) are all font awesome icons

### Environment

Angular CLI: 20.3.10
Node: 20.19.1
Package Manager: npm 10.8.2
OS: linux x64

Angular: 20.3.11
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, router

Package Version
---------------------------------------
@angular-devkit/architect 0.2003.10
@angular-devkit/build-angular 20.3.10
@angular-devkit/core 20.3.10
@angular-devkit/schematics 20.3.10
@angular/cdk 20.2.13
@angular/cli 20.3.10
@angular/material 20.2.13
@schematics/angular 20.3.10
rxjs 7.8.2
typescript 5.8.3

Browsers: Chrome and Safari

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia dalla riproduzione StackBlitz collegata, in particolare da src/main.ts, angular.json e src/global_styles.css. Attiva e disattiva mat-button in Chrome e Safari e confronta le icone Font Awesome con l’icona home di material. Il lavoro è concluso quando le icone mantengono le dimensioni previste e rimangono visibili in entrambi i browser, indipendentemente dalla presenza o meno del pulsante material.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
frontend
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
38/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.