angular / angular/components

bug(cdk/table): CdkTable does not handle column updates correctly when using recycleRows

未关闭
#32,253 2 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
area: cdk/table P3
主要语言
TypeScript
星标
25k
派生
6.8k
平均合并
1 天 8 小时
30 天内合并 PR
91

描述

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

When using `CdkTable` with the table `recycleRows` directive it doesn't look like the table doesn't re-render cached rows not currently in the DOM. This leads to a situation where if those cached rows are later re-used the cells in the row don't match the columns.

It seems like this may be just a matter of clearing the row cache in `_forceRenderDataRows`. This assumes the row elements can't be re-used at all, but that seems to be the current behavior of `_forceRenderDataRows` to re-render everything. It looks like this could be achieved by calling `detach` on the `_RecycleViewRepeaterStrategy` instance in `_forceRenderDataRows`, but it's unclear the semantics of that method since it's not documented in `_ViewRepeater`. `CdkVirtualForOf` only calls it in `ngOnDestroy` and **`CdkTable` never calls it** (probably a separate bug where these row views get leaked when the table gets destroyed).

### Reproduction

StackBlitz link: https://stackblitz.com/edit/mssn6jgh?file=src%2Fexample%2Fcdk-table-recycle-rows-example.ts
Steps to reproduce:
1. Click `Set Short List` to reduce the number of rows to 15 (caching the 10 removed rows).
2. Then click `Toggle Columns`. This forces a full re-render through `_forceRenderDataRows` (which doesn't populate the cache when removing).

### Expected Behavior

All 15 rows re-render correctly

### Actual Behavior

When the 15 rows are re-rendered 5 have the old list of 3 columns since they were inserted from the cache and the remaining 10 are new rows and render correctly.

### Environment

- Angular: 20.2.4
- CDK/Material: 20.2.4
- Browser(s): 141.0.7390.126
- Operating System (e.g. Windows, macOS, Ubuntu): ChromeOS

贡献指南

打开贡献指南

调研方向

使用 src/example/cdk-table-recycle-rows-example.ts 中的 StackBlitz 示例重现该问题,然后检查 CdkTable._forceRenderDataRows 以及 _RecycleViewRepeaterStrategy 的 detach 行为。确认在减少列表后切换列时,会渲染出全部 15 行具有匹配列的行,包括从缓存中重用的行。

由索引模型根据 Issue 内容生成。

评估

技术栈
angular, typescript
领域
frontend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
52/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。