bug(dialog): Typing of new `MatDialogConfig.closePredicate`
- Lenguaje dominante
- TypeScript
- Estrellas
- 25k
- Forks
- 6.8k
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 91
Descripción
### Is this a regression?
- [ ] Yes, this behavior used to work in the previous version
### The previous version in which this bug was not present was
_No response_
### Description
#30919 introduced the new MatDialog config `closePredicate`. I am struggling to make typing work to have a 100% typed code.
### Reproduction
StackBlitz link: https://stackblitz.com/edit/9wtzaa17?file=src%2Fmain.ts
Steps to reproduce:
1. open link, it does not compile, but I expect to compile
### Expected Behavior
At first I expected that types would be flowing, so that I wouldn't need to repeat them. So my expected usage would be like:
```ts
this.dialog.open(
MyDialog,
{
closePredicate: (
result,
config,
componentInstance
) => {
return something();
},
}
);
```
But that failed to compile. So I tried to add typing like so:
```ts
this.dialog.open(
MyDialog,
{
closePredicate: (
result: MyDialogResult | undefined,
config: MatDialogConfig,
componentInstance: MyDialog | null
) => {
return componentInstance?.animal() !== 'my original data';
},
}
);
```
That also fail to compile. And I am out of ideas.
Angular Material source never use this callback with any parameters (neither in implementation, nor in tests).
What is the expected usage pattern here ? Is there a way to avoid repetition ?
### Actual Behavior
Stackblitz does not compile
### Environment
- Angular: 20.1
- CDK/Material: 20.1
- Browser(s): Chrome
- TypeScript: 5.8.3
Guía de contribución
Línea de trabajo
Comienza con la reproducción vinculada de StackBlitz e inspecciona las definiciones de tipos de TypeScript para MatDialogConfig.closePredicate y dialog.open. Compara los parámetros de callback inferidos y anotados explícitamente con el uso esperado; se considera terminado cuando la reproducción compila con valores correctamente tipados para result, config y componentInstance.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- angular, typescript
- Área
- frontend
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 45/100