angular / angular/components

bug(mat-tree): childrenAccessor is not lazily evaluated and leaf nodes are not filtered out before calling the childrenAccessor

Aperta
#31,289 1 commento 6 reazioni 0 assegnatari Vedi su GitHub
area: material/tree P2
Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 8h
PR unite (30g)
91

Descrizione

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

`childrenAccessor` should only be called when expanding a node.

In the current state, workarounds are needed to support a mat-tree which asynchronously fetches children. If the dataset is large enough, there will then be a proportionately large number of fetches for the children.

### Reproduction

StackBlitz link: [stackblitz](https://stackblitz.com/edit/angular18-tree-duplicates-6iwee3dq?file=src%2Fmain.ts)

Notice how the tree eagerly fetches all children, including children of leaf nodes. The number on the bottom of the page indicates the number of times childrenAccessor was called.

### Expected Behavior

`childrenAccessor` should only be called when expanding a node.

Moreover, it should also *not* call the childrenAccessor for nodes which are not expandable, since we already provide the `when: hasChild` predicate.

### Actual Behavior

`childrenAccessor` is eagerly called for each node when the tree is created, including leaf nodes.

### Environment

- Angular: 20
- CDK/Material: 20
- Browser(s): Chrome
- Operating System (e.g. Windows, macOS, Ubuntu): MacOS

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia con la riproduzione StackBlitz collegata in src/main.ts e verifica il numero di chiamate a childrenAccessor per i nodi espandibili e foglia. Traccia l’implementazione di mat-tree responsabile di queste chiamate, quindi conferma che le chiamate avvengono solo durante l’espansione e vengono ignorate per i nodi rifiutati dal predicato when.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
frontend
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.