feat(mat.*-overrides): Improve the styles overrides functions to not generate so much duplicity selectors in the css.
- Dominant language
- TypeScript
- Stars
- 25k
- Forks
- 6.8k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 91
Description
### Feature Description
# Explain the issue
Following your documentation, when we override the style we can do the next:
``` scss
.SELECTOR {
@include mat.*-overrides((
TOKEN_1,
TOKEN_2,
TOKEN_3,
...
TOKEN_n,
));
}
```
But this is translated into css in N duplicate definitios of SELECTOR:
``` scss
.SELECTOR {
TOKEN_1_RESULT;
}
.SELECTOR {
TOKEN_2_RESULT;
}
.SELECTOR {
TOKEN_3_RESULT;
}
...
.SELECTOR {
TOKEN_n_RESULT;
}
```
And they should be filled togeteher in only one SELECTOR:
``` scss
.SELECTOR {
TOKEN_1_RESULT;
TOKEN_2_RESULT;
TOKEN_3_RESULT;
TOKEN_n_RESULT;
}
```
## Example with button
For example to override the button style we can do the next:
``` scss
@use '@angular/material' as mat;
:root {
@include mat.button-overrides((
filled-container-color: orange,
filled-label-text-color: red,
));
}
```
But this is translated into css in two duplicate definitios of :root
``` scss
:root {
--mdc-filled-button-container-color: orange;
}
:root {
--mdc-filled-button-label-text-color: red;
}
```
And they should be filled togeteher:
``` scss
:root {
--mdc-filled-button-container-color: orange;
--mdc-filled-button-label-text-color: red;
}
```
# Explanation of why this should be improved
If we edit a lot of things it generate a lot of unnecessary verbiage that is unefficiency and cause greatly hinders debugging during develmpment.
For example, if we edit 100 Selectors and modify 20 tokens in each one, we have at the end 20 duplicate definitions per each selector that is a total of 2000 selector definitions with one line each instead of 100 selector definitions with 20 lines each.
Logically this makes the final css inefficient as it has many selectors to check, in this case 2000 instead of 100.
# Thanks
Thank you very much for your great work. I hope you correct this, and if there is already a way to avoid these duplicities please let me know and you should add it to the official documentation.
### Use Case
_No response_
Contributor guide
Research direction
Start with the documented mat.*-overrides mixins, especially the button-overrides example, and inspect how multiple token overrides are emitted. Done means the example produces one :root rule containing both custom properties rather than duplicate selectors; compare the generated CSS before and after.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- sass
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100