angular / angular/components

bug(CDK Dialog): aria-hidden is not removed when a child dialog is opened before but closed after a parent dialog.

Abierto
#30,028 0 comentarios 0 reacciones 0 asignados Ver en GitHub
area: cdk/dialog P3
Lenguaje dominante
TypeScript
Estrellas
25k
Forks
6.8k
Merge medio
1 d 8 h
PR fusionados (30 d)
91

Descripción

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

When an application uses routing, the application has its CDK `Dialog` instance (A), and the route's component has its own CDK `Dialog` instance (B), which has A as its parent.

When B opens a component in an overlay, it sets the **aria-hidden** attributes.

When the application provides a set of shared dialog components and a service to open them, they are opened from A, and **aria-hidden** attributes are not set because they are already present. (see [Dialog._hideNonDialogContentFromAssistiveTechnology](https://github.com/angular/components/blob/ef9cff380771da821fbf018b0e58ed4c0600b355/src/cdk/dialog/dialog.ts#L375C11-L375C55)).

When B removes the last dialog (see [Dialog._removeOpenDialog](https://github.com/angular/components/blob/ef9cff380771da821fbf018b0e58ed4c0600b355/src/cdk/dialog/dialog.ts#L348)) while its parent (A) has dialogs open, the aria-hidden attributes are not removed.

This means that because the parent CDK dialog (A) doesn't know that the child dialog had any attributes set, the **aria-hidden** attributes are never removed again, and the application becomes inaccessible to assistive technologies.

### Reproduction

StackBlitz link: https://stackblitz.com/edit/components-issue-starter-aa1qpb
Steps to reproduce:
1. Click on Load Child
2. Click on Show Dialog
3. In the dialog click 'save and close'
4. observe the 'wait dialog' being opened (before the Dialog is closed)
5. the dialog is closed
6. after the wait dialog is closed check the

### Expected Behavior

All **aria-hidden** attributes **set** by dialogs are removed again.

### Actual Behavior

The aria-hidden attributes set by CDK `Dialog` B remain.

### Environment

- Angular: 18.2.8
- CDK/Material: 18.2.8
- Browser(s): Any
- Operating System (e.g. Windows, macOS, Ubuntu): Any

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza en src/cdk/dialog/dialog.ts, en _hideNonDialogContentFromAssistiveTechnology y _removeOpenDialog, siguiendo el flujo de Dialog padre e hijo descrito en la reproducción. Reproduce el escenario de routing del StackBlitz enlazado y verifica después que los atributos aria-hidden establecidos por el diálogo hijo se eliminen tras cerrar ambos diálogos.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
angular, typescript
Área
accessibility, frontend
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
55/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.