angular / angular/components

bug(material/chips): Chips should have larger touch targets

Open
#29,511 0 comments 0 reactions 0 assignees View on GitHub
Accessibility area: material/chips P3
Dominant language
TypeScript
Stars
25k
Forks
6.8k
Avg merge
1d 8h
Merged PRs (30d)
91

Description

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

Even though icon button defaults to 40px, the touch target is still 48px from here: https://gith
ub.com/angular/components/blob/main/src/material/button/_button-base.scss#L126.

Screenshot 2024-07-29 at 2 34 16 PM
Screenshot 2024-07-29 at 2 35 10 PM

Chips has interactive icons buttons or the chip itself is interactive, it should also have a touch target of at least 48x48px to be more accessible

### Reproduction

https://material.angular.io/components/chips/examples

### Expected Behavior

Touch targets of at least 48x48px

### Actual Behavior

Smaller touch targets than 48x48px
Screenshot 2024-07-29 at 2 33 29 PM

### Environment

- Angular:
- CDK/Material:
- Browser(s):
- Operating System (e.g. Windows, macOS, Ubuntu):

Contributor guide

Open the contributing guide

Research direction

Start with the chips examples at material.angular.io/components/chips/examples and compare their interactive chip and icon-button dimensions with the 48px target. Read the referenced src/material/button/_button-base.scss styles, then locate the corresponding chips implementation and tests; done means interactive chips and their icons provide touch targets of at least 48x48px.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, sass, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.