angular / angular/components

bug(MaterialLuxonAdapter): Parsing format for some text inputs fails due to iso check before format check

Ouverte
#28,703 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
area: material/datepicker P3
Langage dominant
TypeScript
Étoiles
25k
Forks
6.8k
Merge moyen
1 j 8 h
PR mergées (30 j)
91

Description

### Is this a regression?

- No

### The previous version in which this bug was not present was

N/A

### Description

In `/src/material-luxon-adapter/adapter/luxon-date-adapter.ts#L174` the date is formatted with ISO before the user provided formats.

This leads to a bug where specific text inputs are not parsing correctly according to the user provided formats.

For example, I provide the format `MMyyyy` to the parse dateInputs array. This gets ignored for certain string inputs. One example is `082001`. This gets parsed as `yyyyMM` by the ISO check before checking my provided formats array and returns incorrectly as `01/0820` instead of the desired `08/2001`.

```
parse(value: any, parseFormat: string | string[]): LuxonDateTime | null {
const iso8601Date = LuxonDateTime.fromISO(value, options);

if (this.isValid(iso8601Date)) {
return iso8601Date;
}

const formats = Array.isArray(parseFormat) ? parseFormat : [parseFormat];

if (!parseFormat.length) {
throw Error('Formats array must not be empty.');
}

for (const format of formats) {
const fromFormat = LuxonDateTime.fromFormat(value, format, options);

if (this.isValid(fromFormat)) {
return fromFormat;
}
}

...
```

### Reproduction

StackBlitz link: https://stackblitz.com/edit/ocbei5?file=package.json
Steps to reproduce:
1. provide the format `MMyyyy` to the parse dateInputs array
2. type 082001 into the date input with luxon date times and tab off to enter

### Expected Behavior

Gets parsed correctly as 08/2001 and displays as 08/2001.

### Actual Behavior

Gets parsed incorrectly by ISO check as 01/0820 and displays as 01/0820.

### Environment

- Angular: 16.0.4
- CDK/Material:
- "@angular/material": "^16.0.3",
- "@angular/material-luxon-adapter": "^16.2.4",
- Browser(s): Chrome
- Operating System: macOS

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Commencez dans src/material-luxon-adapter/adapter/luxon-date-adapter.ts, au niveau de la méthode parse vers la ligne 174, et utilisez la reproduction StackBlitz liée avec le format MMyyyy et l’entrée 082001. Vérifiez l’ordre du parsing et assurez-vous que le résultat s’affiche comme 08/2001 plutôt que 01/0820.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
angular, typescript
Domaine
frontend
Type d'issue
Bug
Difficulté
2/5
Temps estimé
1-3 heures
Activité
À l'abandon
Clarté
Clairement spécifiée
Accessibilité débutants
48/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.