angular / angular/components

feat(progress-bar): Missing `--mdc-linear-progress-active-indicator-shape` property for progress-bar

Offen
#28,554 5 Kommentare 19 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
area: material/progress-bar feature P3
Vorherrschende Sprache
TypeScript
Sterne
25k
Forks
6.8k
Ø Merge
1 T. 8 Std.
Gemergte PRs (30 T.)
91

Beschreibung

### Feature Description

Currently if I want to change the shape of the progress bar to be round like, I only have the `--mdc-linear-progress-track-shape` to set the track shape, but not the same option for the shape of the active-indicator, which will still be square.
Also, only setting the `--mdc-linear-progress-track-shape`, will result in the active indicator overflowing, leaving me with an inconsistent progress-bar (see 1st picture)

Hence that leaves me with the better option of just setting the `border-radius` of the `mat-progress-bar` element itself, because this doesn't cause the active-indicator to overflow. In this case the `--mdc-linear-progress-track-shape` becomes redundant.

1. Screenshot with `--mdc-linear-progress-track-shape: 4px;`, causing the active-indicator to overflow:

image

2. Screenshot with `--mdc-linear-progress-track-shape: 4px;` and `border-radius: 4px`, rendering the `--mdc-linear-progress-track-shape` redundant:

image

3. Screenshot with only `border-radius: 4px;` leaving me with an almost round progress bar, except that the active-indicator is not actually round.

image

So there need to be an option to set the `--mdc-linear-progress-active-indicator-shape` like for other components, so that the active-indicator can be made round, as shown in the [Token and Specs section in the Material 3 specification](https://m3.material.io/components/progress-indicators/specs)

### Use Case

This would enable a very relevant an normal use case that is also shown in the [Token and Specs section in the Material 3 specification](https://m3.material.io/components/progress-indicators/specs).

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Beginne mit der progress-bar-Komponente und verfolge, wie --mdc-linear-progress-track-shape auf den Track und den aktiven Indikator angewendet wird. Vergleiche das Styling mit dem Abschnitt Token and Specs des Material 3 progress-indicator und überprüfe anschließend, dass die neue active-indicator shape option den Indikator ohne Überlauf abrundet.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
angular, typescript
Bereich
frontend
Issue-Typ
Feature
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
55/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.