bug(mat-progress-spinner): stroke-width of svg circle not calculated properly for some diameter + strokeWidth values
- Lenguaje dominante
- TypeScript
- Estrellas
- 25k
- Forks
- 6.8k
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 91
Descripción
### Is this a regression?
- [ ] Yes, this behavior used to work in the previous version
### The previous version in which this bug was not present was
_No response_
### Description
The `circle` element of the `mat-progress-spinner`'s SVG does not fill up to the whole space of it's container. This only occurs for some combinations of `strokeWidth` and `diameter` inputs and only if the `stokeWidth` is smaller than 10.
E.g. for the values of `diameter=10` and `strokeWidth=5` the circle's `stroke-width` style is calculated to be `20.8333%` which is not filling up to the edge of the SVG container:

If the value of the circle's `stroke-width` is manually set to ~26%, it fits:

### Reproduction
[StackBlitz link](https://stackblitz.com/edit/cxwm1t?file=src%2Fexample%2Fprogress-spinner-configurable-example.html,src%2Fexample%2Fprogress-spinner-configurable-example.html)
Steps to reproduce:
1. Use mat-progress-spinner
2. Set strokeWidth to value < 10
3. Set diameter to e.g. 24
### Expected Behavior
The SVG's `circle` element should fill up the whole space of its container element
### Actual Behavior
The SVG's `circle` element does not fill up the whole space of its container element and leaves some space in between
### Environment
- Angular: 17.0.7
- CDK/Material: 17.0.4
- Browser(s): Chrome
- Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu
Guía de contribución
Línea de trabajo
Comienza con la implementación de mat-progress-spinner y reproduce el problema utilizando el StackBlitz enlazado, variando diameter y strokeWidth por debajo de 10. Compara el stroke-width calculado del círculo SVG con los límites del contenedor para los valores indicados y verifica después que el círculo llena su contenedor sin dejar un espacio.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- angular, typescript
- Área
- frontend
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100