angular / angular/components

bug(CdkMenu): Selectable menu items (radio/checkbox) don't stay open when spacebar used

Aperta
#27,818 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
area: cdk/menu P3
Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 8h
PR unite (30g)
91

Descrizione

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

From looking at the cdk/menu code, it seems the intention is for the menu to stay open when selectable menu items (cdkMenuItemRadio/cdkMenuItemCheckbox) are clicked with a CTRL modifier, or if the user uses the space bar.

https://github.com/angular/components/blob/main/src/cdk/menu/menu-item.ts#L194

This doesn't seem to be working (even in the online examples), unless I'm missing something?

https://material.angular.io/cdk/menu/examples

### Reproduction

StackBlitz link: https://components-issue-aea5jm.stackblitz.io
Steps to reproduce:
1. Focus menu button
2. Open menu with ENTER
3. Navigate to one of the buttons (note that they are all MenuItemRadio's)
4. Press SPACE

### Expected Behavior

Menu closes

### Actual Behavior

MenuItemCheckbox should keep the menu open.

### Environment

Latest (based on CDK docs).

---

Angular CLI: 16.1.5
Node: 18.10.0
Package Manager: npm 8.19.2
OS: win32 x64

Angular: 16.1.6
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package Version
---------------------------------------------------------
@angular-devkit/architect 0.1601.5
@angular-devkit/build-angular 16.1.5
@angular-devkit/core 16.1.5
@angular-devkit/schematics 16.1.5
@angular/cdk 16.1.5
@angular/cli 16.1.5
@angular/flex-layout 13.0.0-beta.38
@angular/material 16.1.5
@schematics/angular 16.1.5
rxjs 7.8.1
typescript 5.1.6
webpack 5.86.0
zone.js 0.13.0

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with src/cdk/menu/menu-item.ts around line 194, then reproduce the keyboard interaction in the linked StackBlitz or CDK menu examples. Clarify whether Space should close or keep the menu open for radio and checkbox items, then verify the selected-item behavior matches that decision.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
accessibility, frontend
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.