angular / angular/components

bug(CdkMenu): Selectable menu items (radio/checkbox) don't stay open when spacebar used

Open
#27,818 0 comments 0 reactions 0 assignees View on GitHub
area: cdk/menu P3
Dominant language
TypeScript
Stars
25k
Forks
6.8k
Avg merge
1d 8h
Merged PRs (30d)
91

Description

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

From looking at the cdk/menu code, it seems the intention is for the menu to stay open when selectable menu items (cdkMenuItemRadio/cdkMenuItemCheckbox) are clicked with a CTRL modifier, or if the user uses the space bar.

https://github.com/angular/components/blob/main/src/cdk/menu/menu-item.ts#L194

This doesn't seem to be working (even in the online examples), unless I'm missing something?

https://material.angular.io/cdk/menu/examples

### Reproduction

StackBlitz link: https://components-issue-aea5jm.stackblitz.io
Steps to reproduce:
1. Focus menu button
2. Open menu with ENTER
3. Navigate to one of the buttons (note that they are all MenuItemRadio's)
4. Press SPACE

### Expected Behavior

Menu closes

### Actual Behavior

MenuItemCheckbox should keep the menu open.

### Environment

Latest (based on CDK docs).

---

Angular CLI: 16.1.5
Node: 18.10.0
Package Manager: npm 8.19.2
OS: win32 x64

Angular: 16.1.6
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package Version
---------------------------------------------------------
@angular-devkit/architect 0.1601.5
@angular-devkit/build-angular 16.1.5
@angular-devkit/core 16.1.5
@angular-devkit/schematics 16.1.5
@angular/cdk 16.1.5
@angular/cli 16.1.5
@angular/flex-layout 13.0.0-beta.38
@angular/material 16.1.5
@schematics/angular 16.1.5
rxjs 7.8.1
typescript 5.1.6
webpack 5.86.0
zone.js 0.13.0

Contributor guide

Open the contributing guide

Research direction

Start with src/cdk/menu/menu-item.ts around line 194, then reproduce the keyboard interaction in the linked StackBlitz or CDK menu examples. Clarify whether Space should close or keep the menu open for radio and checkbox items, then verify the selected-item behavior matches that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.