bug(material/datepicker): Adding a max to a datepicker input will fire valueChanges
- Dominant language
- TypeScript
- Stars
- 25k
- Forks
- 6.8k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 91
Description
### Documentation Feedback
Currently the [documentation ](https://angular.io/api/forms/AbstractControl#valueChanges)only says that valueChanges will fire 'every time the value of the control changes' or 'each time you call enable() or disable()' however, I've also found valueChanges to fire if two inputs with datepickers rely upon one another for min and max.
My scenario is a period that has a start and end date. The start date cannot be after the end date, similarly the end date cannot be before the start. So basically my two form fields look like this:
```
```
and
```
```
What I've found is that the valueChanges of startDate will emit whenever the endDate is changed because of the startDate max.
It doesn't seem obvious in the documentation that setting the mib or max will cause the value of the control to change.
Here's a [stackblitz](https://stackblitz.com/edit/reactive-form-validation-angular-15-swfz9e?file=src/app/app.component.html).
Steps to reproduce:
1: Select a start date and see that its value is logged to the console via the valueChanges subscription on startDate.
2: Now make a change to the endDate field and note that the startDate valueChanges emits again.
3: Remove the [max]="period.get('endDate')?.value" from the startDate input and notice that the issue goes away.
### Affected documentation page
https://angular.io/api/forms/AbstractControl#valueChanges
Contributor guide
Research direction
Start with the affected AbstractControl.valueChanges documentation page and reproduce the linked StackBlitz scenario. Confirm when changing the datepicker min/max causes the related control to emit, then update the documentation to describe that behavior; done means the page accurately covers the reported case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100