bug(datepicker): input parse validation broken on custom DateAdapter<numeric>
- 主要语言
- TypeScript
- 星标
- 25k
- 派生
- 6.8k
- 平均合并
- 1 天 8 小时
- 30 天内合并 PR
- 91
描述
### Is this a regression?
- [ ] Yes, this behavior used to work in the previous version
### The previous version in which this bug was not present was
_No response_
### Description
Falsy check of value within [datepicker-input-base._isValidValue](https://github.com/angular/components/blob/a1d5614f18066c0c2dc2580c7b5099e8f68a8e74/src/material/datepicker/datepicker-input-base.ts#L382) leads to invalid numeric date values from custom DateAdapter to be treated as valid instead:
```javascript
! 0
// -> true
! NaN
// -> true
```
-> [parseValidator](https://github.com/angular/components/blob/a1d5614f18066c0c2dc2580c7b5099e8f68a8e74/src/material/datepicker/datepicker-input-base.ts#L150) will never return a 'matDatepickerParse' error.
### Reproduction
Steps to reproduce:
1. Use Custom DateAdapter which returns NaN on invalid()
2. Enter invalid characters on the datepicker's input.
3. Leave datepicker
### Expected Behavior
validation error ('format error') shown/raised.
### Actual Behavior
No error validation error ('format error') will be shown/raised.
([datepicker-input-base._isValidValue](https://github.com/angular/components/blob/a1d5614f18066c0c2dc2580c7b5099e8f68a8e74/src/material/datepicker/datepicker-input-base.ts#L382) should check for 'null' | 'undefined' instead of falsy)
### Environment
- Angular: 15.0.4
- CDK/Material: 15.0.4
- Browser(s): Chrome
- Operating System (e.g. Windows, macOS, Ubuntu): Windows
贡献指南
调研方向
从 src/material/datepicker/datepicker-input-base.ts 开始,重点查看 _isValidValue 和 parseValidator。使用一个在输入无效时返回 NaN 的数值型自定义 DateAdapter 重现该问题,然后验证输入无效字符并离开 datepicker 会产生 matDatepickerParse 验证错误。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- angular, typescript
- 领域
- frontend
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 55/100