angular / angular/components

bug(mat-dialog): mat-dialog-title adds a space in front of the header text when HTML is formatted

Abierto
#26,539 7 comentarios 20 reacciones 0 asignados Ver en GitHub
area: material/dialog P3
Lenguaje dominante
TypeScript
Estrellas
25k
Forks
6.8k
Merge medio
1 d 8 h
PR fusionados (30 d)
91

Descripción

### Is this a regression?

- [X] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

14

### Description

When using a header tag as a mat-dialog-title, there is a space at the beginning of the title, resulting in the dialog title not being aligned with the content:

image

This only happens if the content of the header tag in the HTML file is placed on a new line.

When using a header tag that contains a long expression, the default formatting (by Prettier, for example) puts the content of the header tag on the next line (as header tags are block elements), like so:

```


{{ getTitleThisFunctionHasAVeryLongNameSoPrettierPutsItOnANewLine() }}


```

This results in a space being inserted in the HTML. However, since the browser ignores whitespace at the beginning of the element, the space is not visible (cf. HTML spec).

Sinde Material 15 however, elements containing `mat-dialog-title` have a `::before` element. This element causes the browser to render the whitespace, which is inconsistent with default browser behavior and default formatting for block elements.

### Reproduction

Steps to reproduce:
1. Create a mat-dialog
2. Add a header tag with mat-dialog-title
3. As a header text, insert an expression that is quite long, causing Prettier to put it on the next line

The problem is illustrated in [this Stackblitz](https://stackblitz.com/edit/angular-copgcv?file=src/app/dialog-content-example-dialog.html).

Removing the `::before` element of the `mat-dialog-title`, removes the whitespace, but causes the header height to be too small.

### Expected Behavior

No whitespace should be visible, according to default behavior of both the browser and block element formatting.

### Actual Behavior

Whitespace is visible at the beginning of the title.

### Environment

- Angular: 15.1
- CDK/Material: 15.1.2
- Browser(s): Chrome
- Operating System (e.g. Windows, macOS, Ubuntu): macOS Ventura

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza con el StackBlitz enlazado y su reproducción en src/app/dialog-content-example-dialog.html, y luego inspecciona los estilos de mat-dialog-title relacionados con el elemento ::before. El arreglo está completo cuando un encabezado formateado en varias líneas no muestra espacios en blanco iniciales y conserva la altura correcta del título.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
angular, typescript
Área
frontend
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.